@Stroudy
Posted
Hey, Great job with this solution you should be proud, A few things I noticed,
- Missing a
<meta>
description tag for SEO purposes, - Setting a height and I can see you have added a width attribute to your
<img>
This will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image, - It is best practice to have a
<main>
tag inside your body highlighting the main section. - Links rely on colour to be distinguishable, This applies to your
.attribution
, Low-contrast text is difficult or impossible for many users to read. Link text that is discernible improves the experience for users with low vision. - āUsing
max-width: 100%
ormin-width: 100%
is way more responsive then justwidth:100%
, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail. - You should avoid using
px
as it is an absolute unit and not a responsive unit likerem
orem
, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels. - Another great resource for px to rem converter.
@media
should also be in relative units likerem
orem
,- You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
- Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
- It is best practice to use
margin-inline: auto;
to center left and right then than justmargin: auto;
, You can center the height by using this code snippet
min-height: 100svh;
display: flex;
justify-content: center;
flex-direction: column;
I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! š»
Marked as helpful