Design comparison
SolutionDesign
Community feedback
- @hebaahmedsalehPosted 6 months ago
Great job , we need more accessible markup like in buttons you made them as divs so you can put role="button". you better have readme file contains specs of the task on github not only the deployed link.
Marked as helpful1@eadq001Posted 6 months ago@hebaahmedsaleh ok, thank you for the advice. right now, i just focus on coding a simple designs and make it worth, i haven't put much time to focus on accessibility. maybe in the future when i will build a complex website, i will incorporate both. it's just i focus learning css right now and javascript.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord