Responsive social links profile created with HTML and CSS

Community feedback

• 

  Ebenezer Silva•80

  @Bene001700Posted 18 days ago

  Bom trabalho! Só uma sugestão. Tiraria o "height : 100vh" do body. Não sei por qual motivo ele faz com que o conteiner fique colado no topo. Mas é um bom trabalho. Parabéns.

  Marked as helpful

  1

  ---

  

  MarinaPerezR•50

  @MarinaPerezRPosted 17 days ago

  @Bene001700 Muito obrigada! I will consider your advice!

  0
• 

  RemyJuanes•90

  @RemyJuanesPosted 19 days ago

  The only difference I can see is the links's height, they seem to be just 2 or 3 pixels bigger, good job !!!

  In the HTML:

  You use lot of div tags instead of semantic tags like main for your container. You can wrap you img in a figure and the text inside a figcaption.

  The links are supposed to be a tags, this way, users can click on it to be redirected. If you use button, you had to use JavaScript in order to open a new page

  In the CSS:

  Your CSS file is short, that's a good point for readability. You can use CSS variable declaration to avoid style repetition.

  Marked as helpful

  1

  ---

  

  MarinaPerezR•50

  @MarinaPerezRPosted 18 days ago

  @RemyJuanes Thank you so much for your feedback and your time! I will take all your advice into account 🙏🏻

  0