Responsive Social Links Profile

Community feedback

• 

  Boris•2,870

  @mkborisPosted 3 months ago

  Nice work farruxbek-dev, here are some suggestions for improvement

  • Add a min-height: 100vh; on the body
  • All content should be wrapped within landmarks. Wrap a main tag around the .container and a footer for the attribution.
  • To improve the semantic meaning of these social media links, you should use the a (anchor) tag instead of the button tag. The a tag is used for navigation to other pages, while the button tag is designed for interactive actions like submitting forms or for events like toggling content. Also, using an unordered list ul to group the social media links is a better approach for both semantics and accessibility.
  • Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
  • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset.
  • Media queries should be defined in rem not px

  Hope this helps

  Marked as helpful

  0