Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive Social Links Profile

Farruxbek 140

@farruxbek-dev

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Boris 2,870

@mkboris

Posted

Nice work farruxbek-dev, here are some suggestions for improvement

  • Add a min-height: 100vh; on the body
  • All content should be wrapped within landmarks. Wrap a main tag around the .container and a footer for the attribution.
  • To improve the semantic meaning of these social media links, you should use the a (anchor) tag instead of the button tag. The a tag is used for navigation to other pages, while the button tag is designed for interactive actions like submitting forms or for events like toggling content. Also, using an unordered list ul to group the social media links is a better approach for both semantics and accessibility.
  • Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
  • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset.
  • Media queries should be defined in rem not px

Hope this helps

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord