Responsive Social Links Profile

Community feedback

• 

  Jas•140

  @ajasmine94Posted 10 days ago

  Hi, you did a great job in completing this challenge too! I would just like to leave a few things that I think might help improve the code :)

  • Try to learn Flexbox for easier centering of the container on the page so you won't have to set or fix the margins for each side.
  • You can also learn the use of viewport height (vh) to set the height of the Body element which will eventually help with your positionings.
  • for the following section:

  #git:hover, #front-mentor:hover, #LinkedIn:hover, #Mastodon:hover, #Instagram:hover {
      background-color: hsl(75, 94%, 57%);
  }
  

  It is better to use a class for them since git, front-mentor, linkedin, and so on - all have the same type of element - a button :)

  • And lastly, as part of the best practices when writing a code, it is best to start your IDs or classes with the camelCase or lowercases with hyphens :) Try to also use a more descriptive and consistent naming conventions such as socialLinkButton or social-link-button, and so on.

  I hope these helps! Have a great day / night!

  Marked as helpful

  0

  ---

  

  Daniyal Abbassi Khervi•70

  @daniyal-abbassiPosted 5 days ago

  @ajasmine94 hi my friend. Thank you very much for giving me feedback. honestly, I thought that nobody would ever comment on any of my projects, so this means so much to me.

  0

  

  Jas•140

  @ajasmine94Posted 5 days ago

  @daniyal-abbassi Hello! You're welcome! Glad to be of help because I am also in the process of learning myself! Reviewing other people's work can be a good way to learn new things too, but to be honest, I also felt the same as you before so when I received help and feedback when I first started here really encouraged me to do a lot more, so I've been doing the same favor. :D Let's help each other out!

  0