Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I am proud that I can make the designs more easily.
What challenges did you encounter, and how did you overcome them?Aligning the content was what was most difficult for me
What specific areas of your project would you like help with?In the management of the FlexBox and Grid
Community feedback
- @darryncodesPosted 7 months ago
Hi Javier,
Glad to hear the designs are getting easier - keep going!
A few bits of feedback to help match the design a little more:
- add
min-height: 100vh;to your<body>and remove themargin top/bottomon the.portafolioclass to centre the design nicely in the veiwport - add
background-color: hsl(0, 0%, 12%);to.portafolio, you'll need somepaddingandborder-radiustoo - add
background-color: hsl(0, 0%, 20%);to your buttons - use
cursor: pointer;on the buttons to help indicate visually you can interact with them
A couple of pointers regarding semantic html:
- consider using a
<main>for this element.portafolio - try nesting your
a's in aullist - it's not valid HTML to wrap
button's withatags. You probably just need the links and not the button on this design
I hope this helps. Happy coding 🤙
0@JaviVaSuPosted 7 months ago@darryncodes
Hello
I made corrections based on your recommendations, thanks for your help.
0 - add
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord