Design comparison
Solution retrospective
I'm proud that i was able to make it close to the original though i might try using flexbox to center the content next time instead of margin top and learng
What challenges did you encounter, and how did you overcome them?Had a problem a bit with centering the content by needing to add space to the top i just decided to use margin: 8rem auto; and also problem with width when changing the size of the screen. just decided to stick with min-width:992px
What specific areas of your project would you like help with?Are there better ways to center the main tag? margin-top: auto and margin-bottom: auto doesn't work
Community feedback
- @danielmrz-devPosted 5 months ago
Hello there!
Congrats on completing the challenge! โ
Your solution looks great!
๐ It's recommended to use semantic HTML elements like
<ul>
and<li>
for creating lists. This ensures that your code is more accessible, maintainable, and semantically meaningful.Here's and example on how you can refactor your code:
After Refactoring
<ul class="list-container"> <li><a href="#">Github</a></li> <li><a href="#">Frontend Mentor</a></li> <li><a href="#">LinkedIn</a></li> ... </ul>
By using
<ul>
and<li>
, you convey the structure of your content more clearly, making it easier for screen readers and search engines to understand. Additionally, it aligns with best practices for HTML semantics.I hope you find this helpful!
Keep up the excellent work!
Marked as helpful1 - @kodan96Posted 5 months ago
hi there! ๐
you can center your content with Flexbox if you apply these to the
body
tag:body { min-height: 100vh; display: flex; justify-content: center; align-items: center; }
Hope this was helpful ๐
Good luck and happy coding! ๐
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord