Skip to content
Submitted about 2 months ago

Responsive Social Links

Brian Meinert•160
@bmeinert8
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social links profile
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Steven Stroud•11,910
    @StroudyPosted about 2 months ago

    Exceptional work! You’re showing great skill here. I’ve got a couple of minor suggestions that could make this stand out even more…

    • Using a <main> tag inside the <body> of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content.

    • Overusing <div> tags, known as "divitis," leads to cluttered code, poor semantics, and reduced performance. Instead, use appropriate semantic elements (like <header>, <section>, etc.) to improve readability, accessibility, and SEO. Keep HTML clean and minimal to ensure maintainability, scalability, and better CSS structure.

          <div class="profile">
        <img src="./assets/images/me.jpg" alt="profile picture of Brian Meinert">
      </div>
    • I would put these into a <ul> <li>, and the text should be wrapped with a <a> so it is accessible with a keyboard using the tab key, Using an <a> tag for navigation is semantically correct, improves accessibility for screen readers, and ensures consistent behavior across browsers, unlike a <button> or a <div> not intended for links.
          <div class="links">
        <button class="btn text-preset-2" onclick="location.href='https://github.com/bmeinert8'">GitHub</button>
        <button class="btn text-preset-2" onclick="location.href='https://www.frontendmentor.io/profile/bmeinert8'">Frontend Mentor</button>
        <button class="btn text-preset-2" onclick="location.href='https://www.linkedin.com/in/brian-meinert-b81738256/'">LinkedIn</button>
        <button class="btn text-preset-2" onclick="location.href='https://x.com/bmeinert8'">Twitter</button>
      </div>

    • Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset

    • While px is useful for precise, fixed sizing, such as border-width, border-radius, inline-padding, and <img> sizes, it has limitations. Pixels don't scale well with user settings or adapt to different devices, which can negatively impact accessibility and responsiveness. For example, using px for font sizes can make text harder to read on some screens, Check this article why font-size must NEVER be in pixels. In contrast, relative units like rem and adjust based on the user’s preferences and device settings, making your design more flexible and accessible. Use px where exact sizing is needed, but prefer relative units for scalable layouts. If you want a deeper explanation watch this video by Kevin Powell CSS em and rem explained. Another great resource I found useful is this px to rem converter based on the default font-size of 16 pixel.

    • Using rem or em units in @media queries is better than px because they are relative units that adapt to user settings, like their preferred font size. This makes your design more responsive and accessible, ensuring it looks good on different devices and respects user preferences.

    @media (min-width: 1025px)

    I hope you’re finding this guidance useful! Keep refining your skills and tackling new challenges with confidence. You’re making great progress—stay motivated and keep coding with enthusiasm! 💻

    Marked as helpful
    1
    Brian Meinert•160
    @bmeinert8Posted about 2 months ago

    @Stroudy Thank you for your detailed response, I truly appreciate you taking the time to give me some incredible feedback! I will be sure to implement your shared knowledge in revisions to this project as well as moving forward in others. Thanks again for sharing your time, effort, and knowledge, to help me improve.

    0
    Steven Stroud•11,910
    @StroudyPosted about 2 months ago

    Hey @bmeinert8, No problem, You got this bro! 💪

    0
  • Roberto Keppler•130
    @rkeppler42Posted about 2 months ago

    Hey, Brian!

    Great job, mate!

    The only thing I can think that could improve your solution is that there is no main tag in your html. You could put your container div inside of one!

    Pretty cool use of JS!

    Cheers!

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord