Responsive Social link profile

Community feedback

• 

  P

  Steven Stroud•11,910

  @StroudyPosted 2 months ago

  Hey great job, I noticed on different screen sizes it does something unintended, Few things to consider,

  • Missing a <meta> description tag for SEO purposes,
  • It is best practice to have a <main> tag inside your body highlighting the main section.
  • Having better alt="" descriptions for accessibility is a must check this out Write helpful Alt Text to describe images,
  • Setting a height and width attribute to your <img> will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image,
  • You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset,
  • Line height is usually unitless instead of line-height: 150%; should use line-height: 1.5; this means it is 1.5 x the font-size, unitless value ensures that the line height will scale proportionately.
  • Using vh and vw on anything other than the container is causing your site to do some weird things, Avoid using these units and stick to rem and em for now,
  • ‍Using max-width: 100% or min-width: 100% is way more responsive then just width:100%, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail.
  • Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.

  I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻

  Marked as helpful

  0

  ---

  

  Herika Rajput•120

  @herikarajput3Posted 2 months ago

  Hi, @Stroudy. I really appreciate you taking the time to review my project and point out the mistakes. Your feedback has been incredibly helpful, and I've learned a lot from your suggestions. Thank you so much for your support and guidance!

  1

  

  P

  Steven Stroud•11,910

  @StroudyPosted 2 months ago

  @herikarajput3 Your welcome, I bookmark these tabs and refer back to them when I need to, Happy to help.

  1