Responsive social link profile using angular and flex

Community feedback

• 

  P

  Darkstar•1,100

  @DarkstarXDDPosted 3 months ago

  Looks nice. I have couple of feedback.

  • The <header> or the banner role is usually used to wrap content that is common across multiple pages of a website. Usually you see it at the top of the webpage wrapping the site logo and a navbar. I would not use a <header> in this challenge.
  • What you need is a <main> landmark element. Every web page needs a <main> element wrapping the main content of the page.
  • The <nav> element is for a list of links that navigate within the site. Not for links that navigate to outside websites such as social media sites. In this case having the links inside a <ul> is enough.

  Marked as helpful

  1