Design comparison
Solution retrospective
first time i use media query
What challenges did you encounter, and how did you overcome them?actually i am currently practising flexbox and media query
What specific areas of your project would you like help with?It is good
Community feedback
- @danielmrz-devPosted 5 months ago
Hello there!
Congrats on completing the challenge! ā
Your solution looks great!
š It's recommended to use semantic HTML elements like
<ul>
and<li>
for creating lists. This ensures that your code is more accessible, maintainable, and semantically meaningful.Here's and example on how you can refactor your code:
After Refactoring
<ul class="list-container"> <li><a href="#">Github</a></li> <li><a href="#">Frontend Mentor</a></li> <li><a href="#">LinkedIn</a></li> ... </ul>
By using
<ul>
and<li>
, you convey the structure of your content more clearly, making it easier for screen readers and search engines to understand. Additionally, it aligns with best practices for HTML semantics.I hope you find this helpful!
Keep up the excellent work!
Marked as helpful0 - @AnasIsmai1Posted 5 months ago
You havent employed the styles that were mentioned within the file such as the font, font-weight or the font size. You could improve the button by giving border a none value to remove them out of the equation, use headings for the name and place of stay and larger padding.
0 - @Yahia-kilanyPosted 5 months ago
The design is nice but completely different from the original.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord