Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I like that the design is responsive with 3 different views for different size divices: mobile, tablet and desktop.
What challenges did you encounter, and how did you overcome them?This particular design didn't present any particular challenge.
What specific areas of your project would you like help with?Please look at my code, any feedback is greatly appreciated.
Community feedback
- @mkborisPosted 3 months ago
Nice work cacesasa, here are some suggestions for improvement
- All content should be wrapped within landmarks. Wrap a
main
tag around the .social_wrapper and afooter
for the attribution. - Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset.
- Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
- Media queries should be defined in
rem
not px
Marked as helpful0@cacesasaPosted 3 months ago@mkboris Thank you for the comments. I implemented the changes that you recommended and created a boiler-plate for my CSS reset.
1 - All content should be wrapped within landmarks. Wrap a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord