@Code-Beaker
Posted
Hi there, congratulations on completing this challenge... You've done a great work here! 🎉
I have checked the live site and your source code and I want to share some of my suggestions to improve your site.
- Consider adding
class
names to your HTML elements. This will make it easier for you to style the components. - You can actually declare the components without wrapping them inside a
section
tag. - The links should be wrapped inside an unordered list
ul
. Then, each link should be a a list item. Here's an example of this markup
<ul class="links">
<li><a class="links__link" href="#">GitHub</a></li>
<li><a class="links__link" href="#">Twitter</a></li>
...
...
</ul>
- Make sure your headings are in hierarchical order and they decrease by one level. This is essential in keeping the website accessible.
h1
h2
h3
h4
...
...
- Instead of
px
units, userem
orem
to define properties such as margins, paddings, font-sizes, etc.
These are small but extremely important in making a website. I hope you understand them. If you want to learn further about them, you can find many articles and tutorials online.
Hope you find these helpful 😄