@Stroudy
Posted
Amazing job with this! You’re making fantastic progress. Here are some small tweaks that might take your solution to the next level…
-
This does not matter that much at this stage but something to be mindful of for SEO(Search Engine Optimisation),
<meta>description tag missing that helps search engine determine what the page is about, Something like this<meta name="description" content="" /> -
Using a
<main>tag inside the<body>of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content. -
Using
max-width: 100%ormin-width: 100%is more responsive than justwidth: 100%because they allow elements to adjust better to different screen sizes. To learn more, check out this article: responsive-meaning. -
Developers should avoid using pixels (
px) because they are a fixed size and don't scale well on different devices. Instead, useremorem, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter. -
Using a naming convention like BEM (Block, Element, Modifier) is beneficial because it makes your CSS more organized, readable, and easier to maintain. BEM helps you clearly understand the purpose of each class, avoid naming conflicts, and create reusable components, leading to a more scalable codebase. For more details BEM,
-
Using
remoremunits in@mediaqueries is better thanpxbecause they are relative units that adapt to user settings, like their preferred font size. This makes your design more responsive and accessible, ensuring it looks good on different devices and respects user preferences.
You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟
Marked as helpful
@WellingtonGuedesDev
Posted
Hello Steven, thank you very much for the feedback.
Regarding the meta description tag, it’s really important to use it. I ended up not adding it because I was focused on other parts and completely forgot about it.
I’m reviewing my code, and I did indeed make a mistake in choosing the tag. Initially, I thought about using a <section>, but I ended up using an <article> instead, lol. The use of <section> was because I imagined it would be used as a component, but in this context, it really makes sense to use <main>.
I will modify my code using your tips about width and the use of PXs.
I use, let's say, a "middle ground" version of BEM, lol. I will study a bit more about it to fully implement it.
@Stroudy
Posted
Hello @WellingtonGuedesDev,
Thank you for your thoughtful response! I appreciate your openness to feedback and your willingness to make adjustments. It’s great to see that you’re already thinking critically about the use of tags and components, and recognizing how these small changes can improve the overall structure of your project.
Don’t worry too much about the meta description; it happens to the best of us! The fact that you’re now aware of its importance shows you're always aiming to improve, which is fantastic.
I’m glad you’re finding the tips on using <main> instead of <article>, and the considerations around width and px useful. Those little tweaks will definitely enhance the clarity and consistency of your code.
As for BEM, adopting a "middle ground" is a good start, and diving deeper into it will definitely help make your code even more maintainable and scalable. It’s all about continuous learning and growth!
Keep up the excellent work, and I’m excited to see how your project evolves! 😊
