Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive site with flexbox

P
Dzik0 180

@Dzik0

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Adriano 36,650

@AdrianoEscarabote

Posted

Hello Dzik0, how are you? I was really pleased with your project, but I’d like to offer some advice that might help:

Since this project is only based on a single page component, there is no need for a h1 tag. It's always a good idea to prevent accessibility errors, so I believe it would be beneficial for you to add a "h1" in this component. Don't worry if you forget about "h1," though; it's a good practice for when you are developing larger sites.

<h1>Welcome to 3-column preview card component</h1>

I noticed that you used a button in which case the best option would be an a, because in my head when a person clicks on a button written Learn More, he is not confirming a form, or something like, it will be redirected to another page, to Learn More about!

to solve this problem do this:

<a href="/">Learn More</a>

The rest is spot on.

Hope it’s helpful to you. 👍

Marked as helpful

1

P
Dzik0 180

@Dzik0

Posted

Thank you very much for your feedback! Will defenietly think about <a> instead of button next time!

0
P
Lo-Deck 2,460

@Lo-Deck

Posted

Hi well done for this challenge,

You need to use more semantic tag to improve your HTML, it's better for screen-reader and SEO.

Use a div when there is no other choices, you can use section, article...

It's better to use em or rem instead of px. FreeCodeCamp. FreeCodeCamp.

Hope to be helpful.

Marked as helpful

1

P
Dzik0 180

@Dzik0

Posted

Thanks so much for your time. I have to defenietly work on using more semantic tags to improve my html and em/rem instead of px!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord