Responsive site with flexbox

Community feedback

• 

  Adriano•38,230

  @AdrianoEscarabotePosted about 1 month ago

  Hello Dzik0, how are you? I was really pleased with your project, but I’d like to offer some advice that might help:

  Since this project is only based on a single page component, there is no need for a h1 tag. It's always a good idea to prevent accessibility errors, so I believe it would be beneficial for you to add a "h1" in this component. Don't worry if you forget about "h1," though; it's a good practice for when you are developing larger sites.

  <h1>Welcome to 3-column preview card component</h1>
  

  I noticed that you used a button in which case the best option would be an a, because in my head when a person clicks on a button written Learn More, he is not confirming a form, or something like, it will be redirected to another page, to Learn More about!

  to solve this problem do this:

  <a href="/">Learn More</a>

  The rest is spot on.

  Hope it’s helpful to you. 👍

  Marked as helpful

  1

  ---

  

  P

  Dzik0•240

  @Dzik0Posted about 1 month ago

  Thank you very much for your feedback! Will defenietly think about <a> instead of button next time!

  0
• 

  P

  Lo-Deck•2,790

  @Lo-DeckPosted about 1 month ago

  Hi well done for this challenge,

  You need to use more semantic tag to improve your HTML, it's better for screen-reader and SEO.

  Use a div when there is no other choices, you can use section, article...

  It's better to use em or rem instead of px. FreeCodeCamp. FreeCodeCamp.

  Hope to be helpful.

  Marked as helpful

  1

  ---

  

  P

  Dzik0•240

  @Dzik0Posted about 1 month ago

  Thanks so much for your time. I have to defenietly work on using more semantic tags to improve my html and em/rem instead of px!

  0