Responsive site using Tailwind CSS

Community feedback

• 

  Adriano•38,330

  @AdrianoEscarabotePosted about 2 years ago

  Hi Noela Ost, how are you?

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  • The links must have an aria-label or sr-only text that tells where the link navigates the user. For example: Visit our Facebook. For images, you should set aria-hidden=” true” to be ignored by screen readers and to avoid redundancy and repetition.
  • You have used <br> , using <br> is not only bad practice, it is problematic for people who navigate with the aid of screen reading technology. Screen readers may announce the presence of the element. This can be a confusing and frustrating experience for the person using the screen reader. You can read more in MDN.

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  0

  ---

  

  Noela Ost•150

  @NoelaOstPosted about 2 years ago

  @AdrianoEscarabote Hey there, thank you for taking time to comment on my challenge. I always like return a favor by marking comments as helpful.

  I'd like to have another advice from you though. My question is how would you solve heading in this case? I decided to separate it with <br>, but I was also thinking of using <h1> and <h2> tags. Not sure whether that was good idea either, so I just went with <br>. Thanks in advance.

  1

  

  Adriano•38,330

  @AdrianoEscarabotePosted about 2 years ago

  @NoelaOst Right! currently I've been using width and max-width, so if I want to make the line break element I use a smaller max-width! and to make the content responsive I put the width: 100%;.

  happy coding!!

  Marked as helpful

  0

  

  Noela Ost•150

  @NoelaOstPosted about 2 years ago

  @AdrianoEscarabote Ok thanks man! Happy coding to you as well!

  1