Skip to content
Submitted over 1 year ago

Responsive site using material ui and react

Varghab Shib•50
@Varghab
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Intro section with dropdown navigation
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

I have two questions for the community 🚀

  1. What are the best practices I could follow to improve my project?
  2. As I am using Material-UI, I want to know how we can conditionally render the styles of components in material ui.

Community feedback

  • Luka Glonti•3,440
    @lack21Posted over 1 year ago

    Good work 👍, but I have a suggestion!

    • Replace height: 100vh to min-height: 100vh in the .MuiBox-root css-q1iihw, the difference is that, when you set height: 100vh to something, that means it won't be bigger than that, it might cause some problems in the future, so better approach is to set min-height: 100vh, like this in case content is overflowing container will adjust to it.
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord