Design comparison
Solution retrospective
I have a question, so.... how do i make my code more organized? I really try to make it clean as possible, but i have the felling it stay a lot messy mainly the css.
Community feedback
- @leyuaPosted about 2 years ago
Hi @Jonata-tr , Congratulations on completing the challenge!
Here is my feedback:
- It will be simpler if you write
.hidden { display: none; }
in the css file and then add the "hidden" class to the section you want to hide. If you use toggle in JavaScript, you can easily add and remove the class.
-
An inline element can't contain a block-level element. but <span> tag is inline element and <p> tag is block element. I recommend changing
<span class=""><p></p></span>
to<p class=""> </p>
. -
<h> tag and <p> tag are block elements, so you don’t have to wrap them with div tags.
I hope this feedback helps.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord