Responsive Site Product preview card component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @Rafael-Urei 👋, good job on completing this challenge! 🎉

  Here are some suggestions you might consider:

  • In this challenge, you should not use the background property to set the image because this image has semantic meaning. Use the CSS background property if the image is not part of the content.
  • You can use a <picture> tag when you need to change an image in different viewports. Using this tag will prevent the browser from loading both images, saving bandwidth and preventing you from utilizing a media query to modify the image.

  <picture>
     <source media="(max-width: 460px)" srcset="./media/images/image-product-mobile.jpg">
     <img src="./media/images/image-product-desktop.jpg" alt="your_alt_text">
  </picture>
  

  • The <h1> element is the main heading on a web page. There should only be one <h1> tag per page. The HTML Section Heading elements (Reference)

  <h1 class="category">PERFUME</h1> is not a heading element.

  • The <div class="button"> container should be a button and not a div element.
  • You could use the <del> tag to display the old price:

  <del class="main_price">
     <span class="sr-only">Old price: </span>$169.99
  </del>
  

  Note that I added the <span> with the sr-only class to the del element, this will provide more information about what your old price is about.

  The sr-only class is a class that you can add to hide content visually but is only visible to screen-readers. More information here.

  I hope those tips will help you.

  Good job, and happy coding!

  Marked as helpful

  2

  ---

  

  Rafael de Souza•110

  @Rafael-UreiPosted about 2 years ago

  😁 Hi @MelvinAguilar!!!! Thanks for the tips!!! 🎉 i really have this problem with acessibility and I forget all the time that I must use semantic tags in my code and I'm using HTML5 kk, it's very important. I'll update my code accord this tips, and learn more about these "del" and "span" tags. I'm so gratefull!

  1