Responsive Site (Mobile-First) Flexbox

Community feedback

• 

  raya•2,870

  @rayaattaPosted 11 months ago

  hello 👋 Hunter Mann, congratulations on completing this challenge 🎉 I have some suggestions you might find useful. 1, It is better to keep your html and css in different files because separating them improves performance since the browser parses the html and caches the css on subsequent visits 2 In order to actually center the card on any screen Add this to your body min-height:100vh. 3 Try merging these

  <main>
      
      <div class="container">
  

  Into

  <main class="container">
  

  And

  <footer>
    <div class="attribution">
  

  into <footer class="attribution"> Do not create parent elements when a child element could exist quite happily on its own.

  3 Text should not be wrapped inside sectioning element rather the parent shouls be given a child element for text such as span,p,h2 etc Wrap the text inside your footer inside a p

  I hope this helps

  Nice solution bro👏*

  0