Design comparison
Solution retrospective
Used grid to style the component.
What challenges did you encounter, and how did you overcome them?Faced some issues while using media queries so I had to look that up.
What specific areas of your project would you like help with?Possibly making sites responsive and semantically correct.
Community feedback
- @Alex-Archer-IPosted 6 months ago
Hi!
It's quite a neat work, cool =)
Bu you can take more from
picture
tag, by the way =) This tag should contain oneimg
and differentsource
tags:<picture> <source srcset="mobile.jpg" media="(max-width: 40rem)"> <img src="desktop.jpg" alt=""> </picture>
This way the
picture
will check media conditions from thesource
tags and choose one of them. If no one condition match it'll displayimg
. Also you can changedisplay
ofpicture
toblock
and style it directly without wrapping div. The less tags, the better =)Except
main
tag. Every page should containmain
tag.Hope that could help =) Keep doing =)
Marked as helpful1@ishika-santhaliaPosted 6 months agoThanks for the advice Alex! I'll implement it from now on :)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord