Skip to content
Submitted almost 3 years ago

Responsive site

Clarice Almeida•65
@ClariceAlmeida
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Base Apparel coming soon page
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

This was my first challenge using JavaScript, please feel free to give feedbacks.

Community feedback

  • David Osorio•560
    @osoriodevPosted almost 3 years ago

    Hello @ClariceAlmeida 👋

    You have some issues with your HTML, for example:

    • You are using an a tag to send email, it must be a button, the a tag is for links only
    • The <div id="text"> must be an h1 tag
    • The text tag is not a valid html tag, you can use other tags instead, for example span

    As for JavaScript, I recommend that you use regular expressions for validation.

    Overall, your design looks great. I hope it helps. 👍

    Marked as helpful
    0
    Clarice Almeida•65
    @ClariceAlmeidaPosted almost 3 years ago

    @osoriodev Thank u very much, I did the changes and it looks better. However I don't think I know how to use regular expressions yet.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord