Responsive single price page using CSS grid

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  Hello, Aghnia! 👋

  Congratulations on completing your first Frontend Mentor challenge! 🎉 Great work on this one! 👍

  Here are a few things I'd like to suggest,

  • Not wrapping a button element inside a link element. An element should either only be one or the other. In this case, I think the "Sign up" element would be good to be a link since elements of that sort typically take you to a sign up/login page. 😉
  • Adding a favicon to the site. There should be one in the starter files for this challenge that you can use.
  • Avoiding using px for setting the value of font-size in your styles. Instead, use a responsive unit such as em or rem so that users will be able to change the size of the text in your site by changing the default font-size of their browser. It might also be worth setting the values for other properties such as margin or padding in those units so that your entire site will scale with the user's chosen default font-size. If you'd like to learn more about those units in CSS and how all of this works, check out this helpful video on the topic.

  Hope you find these suggestions helpful. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  2

  ---

  

  Aghnia•30

  @aghniputraPosted over 2 years ago

  Hi @ApplePieGiraffe, thank you so much for your suggestions and the video :)

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  @aghniputra

  No problem! 😊

  0