Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive Single price Grid Component using CSS Grid and Flex

Muhammadh 1,140

@Mr-jaw

Desktop design screenshot for the Single price grid component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


13th Challenge completed

A single Price Grid Component Using CSS Grid and Flex

Any Feedbacks on improving my accessibility and semantic coding is greatly appriciated

Solution GitHub: git-hub-repo

Live Site: Live-site

ThankYou! 😊

Community feedback

P
Alper 1,010

@adonmez04

Posted

Hi, @Mr-jaw. It's a really good solution. Keep coding. I have some suggestions for you.

1 - You can add min-width:311px to .container for the mobile version.

2 - I highly recommend to use one direction margin like margin-bottom. This way you can avoid margin-collapse and your code will be more readable.

3 - I think you don't need three section tags here. Because they don't separate main to three part. They are in the same area. You can use one section tag and inside three div elements.

4 - You also don't need to give a class name to your main element in the page. main element is a unique element in the page like body. You can add some layout properties to main with div.

And congratulations to your 13th Challenge. I hope I'll reach this point but for now, I can't imagine:), I spend lots of energy to solve these projects, 13th Challenge is dreamy for me. They are really hard but so beneficial for us.

I hope these will help you to improve your perspective. Keep coding. All the best.

Marked as helpful

1

Muhammadh 1,140

@Mr-jaw

Posted

@adonmez04 Thanks for the review 😊

I'll look into the things that you pointed out

Also, good luck on your journey as well

1

@sezimarjr

Posted

it's not exactly feedback but your code is amazing it helped me understand some GRID concepts Thanks :D

0

Muhammadh 1,140

@Mr-jaw

Posted

@EvolxTV Thanks for the review tho 😊

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord