Responsive Single Price Grid Component using CSS Flexbox

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted over 1 year ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Remove all the article and section elements you added as they are being used incorrectly ❌, since this is a component.

  • Your "button" was created with the incorrect element ❌. When the user clicks on the button they should be directed to a different part of you site. The anchor tag will achieve this.

  • In your CSS file, you want to ensure you are checking ⚠️ for any repeated code to remove it and are utilizing your variables constantly.

  More Info:📚

  MDN The Anchor element

  • There is no need ⚠️ to nest your styles in this .container > section > article:first-child manner. Instead target the class of the element you wish to style. This will make it easier to maintain as your project sizes increase.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 👾

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  POINTING CURSOR ↗️:

  • Looks like the component's button element has not a pointer, this property plays a major-role in terms of both UI & UX

  ---

  • Actually before moving to pointer you can better change the input into actual button element, because for semantic reasons button element is highly appreciated.

  ---

  • The cursor: pointer CSS property is important for button-like elements because it changes the cursor from the default arrow to a pointer when hovering over the element. This provides a visual cue to the user that the element is clickable and encourages interaction.

  ---

  • In terms of UI/UX, using cursor: pointer helps to improve the usability of the interface by making it easier for users to identify interactive elements. It also helps to provide feedback to the user by indicating which elements are clickable and which are not.

  ---

  • So we want to add this property to the following button element (At this point you already changed input intro button as per suggestion)

  button {
     cursor: pointer;
  }
  

  • Now your component's button has got the pointer & you learned about this property as well

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  P

  Brice THIBAULT•100

  @DarkjuliusPosted over 1 year ago

  Thanks for the semantic reminder. So I took it back and tried to make it as simple as possible. I inserted classes when needed. I also changed the type of the button because it's a submit. I updated my repository and it is taken into account. Once again thank you and have a nice Sunday.

  0
• 

  P

  Brice THIBAULT•100

  @DarkjuliusPosted over 1 year ago

  Hello and thank you for your feedback. Indeed, you are right. I made the changes in my code and checked. The update is effective on my repository.

  0