Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive single price grid component solution (SASS, BEM)

@denissejoyce

Desktop design screenshot for the Single price grid component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I liked the button animation I added!

What specific areas of your project would you like help with?

I'd be so thankful to anyone who can review my use of BEM and semantic HTML (I'm trying to focus on accessibility also)!

Oh, and lastly, any tips on how you guys name your CSS/SASS variables, please? I understand that you have to be descriptive, but with projects that have lots of colors, for example, how do you name your variables?

Thank you 🫡

Community feedback

haquanq ®️ 1,585

@haquanq

Posted

Hello @denissejoyce 👋👋👋

Nice work on the challenge!! It is looking good and close to the design. I notice that you are using extra hidden heading (sr-only) and it is good practice (improve semantic).

Here is my feed back for you:

  • About naming classes, instead of naming it with parent & child relationship, for each small section you can pick an unique name for it. For example,
// you can flat it out to avoid deep nesting
intro__section
    intro__title
    intro__subtitle
    intro__description
subscription__section
    subscription__title
    subscription__price
    subscription__description
    subscription__link
why__section
    why__title
    why__list
        why__item
  • About naming variables (colors), depend on the scale of the project you could simply name all the variants of each color such as color-500, color-600 and use them directly. Or if you want your system to be more robust you can define local colors variable for each component like item--clr-hover and use it for itself or child elements. However since you are using SASS, there are so many way to utilize functions/mixins to solve different problems. At the end, you need to practice a lot to figure out what do you need.

Hope this help 🌴🌴🌴

Marked as helpful

1

@denissejoyce

Posted

Hi @haquanq, thank you for taking the time to review my code! I'll make sure to apply your (really helpful!!!) suggestions to my next FEM challenge solution ☺️

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord