Design comparison
Solution retrospective
Feel free to take a look at my code and suggest any improvements. It'll be appreciated!
Community feedback
- @mohamed-benoughidenePosted about 2 years ago
Hi @OhSorrow β great job completing this challenge it looks that you didn't follow best practices in your html witch is not using a level-one heading
it's best practice to start your component with h1 because Screen reader users can use keyboard shortcuts to navigate directly to the first h1. in this challenge It wouldn't matter lot but when you work on a bigger project it's gonna make a bigger impact on the usability of your website, so you can just change h2 tag in line 14 to an h1.
finally, I hope you find my feedback helpful if so please upvote me and mark it as helpful π.
1@OhSorrowPosted about 2 years ago@mohamed-benoughidene Hi dear Mohamed! Thanks for your guidanc! βΊοΈ
As you mentioned above, in this challenge which is a component, it's not a big deal but I surely use
h1
to improve accessibility in large projects.0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord