Responsive single price grid component created with CSS Grid
Design comparison
Solution retrospective
Hey everyone.
This was my third challenge but it was my first time using Grid so I'd appreciate any feedback.
Thank you very much! :)
Community feedback
- @MojtabaMosaviPosted over 3 years ago
Hi!, the mobile view looks nice but not on dektop. You need to think more about using the appropriate tag for a specific task (semantic markup), in you code you have only used div which work but it's not the best solution.
Keep coding :)
0@hyundonnyPosted over 3 years agoHello @MojtabaMosavi!
Thanks for your feedback.
You're absolutely right that I should use better tags. I'll keep that in mind in my next challenge.
On a different note, could you be a little more specific about the desktop view not being as nice as the mobile view? It seemed to work just fine when I tested out a few different desktop sizes in Chrome.
Thanks again for your feedback! :)
0@MojtabaMosaviPosted over 3 years ago@hyundonny of course, What I meant was that (only my opinion) your media query for desktop view could be defined on smaller screen around 700px and once again this is only my opinion.
Keep coding :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord