Responsive single price component (CSS Grid and Flexbox)

Community feedback

• 

  Szymon Rojek•4,540

  @SzymonRojekPosted almost 4 years ago

  Hi Tazzz,

  Another project done, well done:D

  I have checked your HTML structure, a few tips from me:

  • these styles CSS in the head transfer to the CSS file;
  • I think instead of div class box you can use the main tag;
  • also there is not necessary to create three sections because this is a one small component and will be better to put just a 3 divs (divs are perfect for generic groupings of content);
  • instead of button you can use a link because you want to move just to another part of website;
  • putting ul > li inside of p tag it is unnecessary;
  • I'd recommend reading more about tags (why they matter and when using them because it is very easy to overuse them too);
  • classes should be readable and descriptive so maybe it will be good to learn BEM naming convention.

  Ps. Don't forget to upvote any comments on here that you find helpful.

  Greetings :D

  1

  ---

  

  Tazzz•60

  @ta-zzzPosted almost 4 years ago

  @SzymonRojek Hello Szymon! Thank again for giving your feedback. I'll definitely take note for my next project : D

  0