@Stroudy
Posted
Hey great job getting it so close to the original, some things I noticed,
- Missing a
<meta>description tag for SEO purposes, - Setting a height and width attribute to your
<img>will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image, - Line height is usually unitless instead of
line-height: 150%;should useline-height: 1.5;this means it is 1.5 x the font-size, unitless value ensures that the line height will scale proportionately. - You should also use relative units for
@mediaaswell,
Smashing it, Great code in all honesty, I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻
@steffieMD
Posted
@Stroudy
Hiiii, thank you so much! I'll get on this. Thank you so much for the info on the line-height! i'll definitely take note.
Regarding the height of the image, i thought fixed <img> heights can tamper with the responsiveness of the page. Also, for the media queries the only place i didn't use relative units was the border radius. I'm meant to use relative units there as well yeah?
Again, thank you sooo mucch :)
@Stroudy
Posted
@steffieMD, Hey,
- HTML, It provides a fallback size for browsers, Settting the width and height attributes to define the intrinsic size of the image. This helps the browser allocate space for the image while it's loading, reducing layout shifts.
- Use CSS to control the image size responsively, ensuring it looks good across all devices.
Hope this was a good explanation and helpful, Happy Coding!
Marked as helpful
