Responsive sign-up form

Community feedback

• 

  Joseph Wamiti Mugo•40

  @Wamiti8711Posted over 2 years ago

  hello Franco please can we plan on a session where you can teach me how i will improve this site....we can use liveshare on vscode

  0
• 

  Lorenzo Franco•480

  @LfrancosPosted almost 3 years ago

  Hello Joseph!

  This is looking really nice!

  There are 3 things that I'm seeing that can be improved.

  -The first one is that the email input is accepting values that are not emails. You can take a look at my solution an see what I did to fix that.

  • I think this is an important one and it is that the form is not submitting once all the values are accepted.

  -And lastly is the responsiveness of the site. I highly encourage you to put max-widths to the more important elements. I'm saying this because your form is not keeping the same width as the price card. You added a "max-width: 500px" to the form but the pricing card not so it gets bigger and looks weird when it can grow more that that. I would suggest to add that max-width to the "form-container" that way you can make sure that all the items with-in them will keep the same width.

  Hope this makes sense and helps you : )

  0

  ---

  

  Joseph Wamiti Mugo•40

  @Wamiti8711Posted almost 3 years ago

  @Lfrancos Thank you brother, sure i will rectify the mistakes and this is very helpful..Am looking forward to work with you on more projects...currently learning javascript

  1
• 

  Joseph Wamiti Mugo•40

  @Wamiti8711Posted almost 3 years ago

  The best way to learn code is by having friends in the same situation as you

  0
• 

  bikeinman•1,080

  @BikeInManPosted almost 3 years ago

  Nicely Done. Works well in both sizes. I like the tick icons for valid fields. Nice touch.

  0

  ---

  

  Joseph Wamiti Mugo•40

  @Wamiti8711Posted almost 3 years ago

  @BikeInMan Thanks Bike

  0

  

  Joseph Wamiti Mugo•40

  @Wamiti8711Posted almost 3 years ago

  @BikeInMan Looking forward to do one challenge, learn and practice building code with you

  0

  

  Joseph Wamiti Mugo•40

  @Wamiti8711Posted almost 3 years ago

  @BikeInMan Are you in the slack community

  0

  

  bikeinman•1,080

  @BikeInManPosted almost 3 years ago

  @Wamiti8711 Sorry, I am not in slack. But I will check out your solutions when you submit here. Just a caution, I am just a "newbie" to front-end development, so I am afraid, my advice may not be very accurate. Just keep practicing, you will get reach much higher in no time.

  0

  

  Joseph Wamiti Mugo•40

  @Wamiti8711Posted almost 3 years ago

  @BikeInMan Am also a newbie.....fear can destroy your journey just be real to urself since everyone has been a newbie at somepoint

  0

  

  bikeinman•1,080

  @BikeInManPosted almost 3 years ago

  @Wamiti8711 wise words from a young man. I'll keep that in mind. For me I never had to work on front-end. When I HAD too, it was just a disaster. That's why I decided to really learn. It's been only a little more than 2 months. But I am working very hard now, but I started to like CSS a lot.

  0