Responsive Signup Form

Community feedback

• 

  nanc•940

  @naiiidenPosted almost 3 years ago

  I was struggling with this challenge for 2 days until I was playing around with my code... I removed the "required" attribute from the <input> tag and my JS worked. For unknown reason this interferes with JS :thinking:

  0

  ---

  

  Kamasah-Dickson•5,590

  @Kamasah-DicksonPosted almost 3 years ago

  @naiiiden Oh really? I have not thought of that. Besides thanks for the comment, I appreciate.

  0
• 

  Aakash Verma•6,710

  @skyv26Posted almost 3 years ago

  Hello! Kamasah, I checked you work and I have noticed some issues.

  1. Never fix your footer with absolute or fixed property unless it is necessary. Your design is responsive but as move below 375px screen then you main heading/title moves outside the
     scope.

  2. You have use form elements inappropriately, because of that your form validation is not working. Please go throught your work again try to understand what you have done. **Hint: check your form submit button TYPE **

  3. I have question why you used inbuilt form validation, because in this challenge you had to implement custom form validation. So i would say stick with requirements. It is really important. Suppose any random client of you, give some work and he/she have some dedicated requirement then you can't give him work of your own choice. (I hope you understand what I am meant to say)

  Best of luck

  0

  ---

  

  Kamasah-Dickson•5,590

  @Kamasah-DicksonPosted almost 3 years ago

  @skyv26 I really appreciate your opinion. I am a self thought frontend developer and I want to improve upon my CSS and HTML am now learning Javascript that is why I used inbuilt Form Validation. I will update this when I become friendly with Javascript. @skyv26 Thanks for your opinion.

  1

  

  Aakash Verma•6,710

  @skyv26Posted almost 3 years ago

  @Kamasah-Dickson I hope you will be soon an expert frontend developer.

  1