Design comparison
Solution retrospective
this project help me to use BEM in my CSS and improve my skill in HTML/ CSS notably in Js. in my Js i repeat a same instruction with different var so can you help me for improve my code base (●'◡'●)
Community feedback
- @placetenoPosted about 2 years ago
Hello Ouattara,
Like Adriano mentioned, the final result of your project looks great, very close to the original design. Well done!
I just wanted to encourage you to use
rem
as your main unit throughout the whole project instead ofpx
. There's nothing wrong with pixels, but they are not as responsive asrem
, especially if a user has a differentfont-size
in their browser other than the regular 16px. Also, try resetting yourmargin
andpadding
and settingbox-sizing: border-box
at the top of your stylesheet using the universal selector*{...}
. That will make your life much easier! 😃I hope this helps!
Marked as helpful0 - @AdrianoEscarabotePosted about 2 years ago
Hi Ouattara, how are you?
I really liked the result of your project, but I have some tips that I think you will enjoy:
- images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty
alt=""
and addaria-hidden="true"
attributes to make all the assistive technologies of the Web, as screen reader. Learn the differences between decorative/meaningless images vs important content.
The rest is great!
I hope it helps... 👍
Marked as helpful0 - images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord