Responsive Sign Up Master Intro Component with Javascript.

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  Hi, Caleb Sim! 👋

  Congratulations on finishing this challenge! 🎉

  For the error icon, I recommend making it the background image of the input element. So, there's no need for extra HTML markup to show the error icon.

  For the JavaScript, here are some suggestions:

  • Firstly, I recommend formatting the code in a consistent way. You can use code-formatter like Prettier or even let your code editor automatically format the code. This way, it will be much easier to understand the code.
  • Secondly, I recommend having the password criteria always visible on the user interface. Having the password criteria on the browser's console won't help your users.
  • I recommend using all classes begin with js- to select DOM elements within the JavaScript. Keep in mind, that only use the js- classes only for JavaScript purposes.

  const form = document.querySelector(".js-form");
  

  For the HTML:

  • <container> is not a valid HTML. Use valid HTML markup.
  • input must have a label. I recommend using aria-label to give each input a label.

  Currently, there's no way for the screen readers to pronounce the error message. So, I recommend doing some research on this. You can see my solution as your reference.

  I hope this helps! Happy coding!

  1