Responsive Sign up Form HTML CSS JS

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi there! 👋

  The most difficult part of this challenge was to create RegEx to validate each type of input. It's hard to create just a good RegEx. However, I managed to create the RegEx that I wanted and it worked well! 😄

  Now, I have a few suggestions for this solution.

  • The error icon should be a background image instead of an actual image element.
  • Each input element should have label. So, I recommend having a sr-only label or making the label as placholder.
  • Specify the type of the button element to prevent it from behaving unexpectedly.
  • Add an id and aria-live to each error message element, and then add aria-describedby that point to the error message for each input element. Also, by default the error element should be hidden by making it display: none; or using hidden attribute. By doing this, it will make the error messages get pronounced by the screen readers.
  • I think switch statement would be a better choice in this case. It's much easier to read and understand in my opinion.

  That's it! Happy coding! 😁

  Marked as helpful

  1

  ---

  

  Julio Velezmoro•220

  @LakorthusPosted over 2 years ago

  @vanzasetia thank you very much I will start working In your suggestions! Thank you very much for your feedback!

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @Lakorthus No problem! 😉

  0