Design comparison
Solution retrospective
I know i should do more component, especially inside for the Homepage component. I wanna do this fast, i got some any in my typescript but i think i did a great job.
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi Nathan Zed, how are you?
I really liked the result of your project, but I have some tips that I think you will enjoy:
- We have to make sure that all the content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.
Example:
native HTML5 reference elements:
<body> <header>This is the header</header> <nav>This is the nav</nav> <main>This is the main</main> <footer>This is the footer</footer> </body>
ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:
<body> <div role="banner">This is the header</div> <div role="navigation">This is the nav</div> <div role="main">This is the main</div> <div role="contentinfo">This is the footer</div> </body>
It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.
Link to read more about: click here
The rest is great!
I hope it helps... 👍
Marked as helpful0@TKSHIIPosted about 2 years ago@AdrianoEscarabote Thank you so much for your answer ! Its really helpful, i appreciate, thanks mate 👍
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord