Design comparison
SolutionDesign
Solution retrospective
Any recommendation will be appreciated ♥.
Community feedback
- @fatlindshehuPosted over 2 years ago
Hi, The component looks great, and the code looks pretty understandable, I would mention one tiny detail:
- When using the outline on the button, the buttons size increases, (Because the outline is given out of the border), in bigger projects that can cause your site to move a tiny bit and it makes it harder to make it pixel perfect, I would recommend using
box-shadow: inset 0 0 0 1px var(--color-white);
this adds an outline within the content and the button doesn't move. - I would also avoid using rem & em together, instead I would choose one, and stick to that.
Marked as helpful0 - When using the outline on the button, the buttons size increases, (Because the outline is given out of the border), in bigger projects that can cause your site to move a tiny bit and it makes it harder to make it pixel perfect, I would recommend using
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord