Responsive Sass practicing BEM and SMACCS style organization

Community feedback

• 

  Szymon Rojek•4,540

  @SzymonRojekPosted almost 4 years ago

  Hi Michael,

  Welcome here, and well done :D

  I have checked your HTML structure, a few tips from me:

  • alt text => don't need to use words like picture or image, photo, icons in the alt text as it's already announced as being an image;
  • I don't recommend using two sections in this project => I think one will be ok;
  • instead of section class="card__stats" you can use ul > li;
  • h2 doesn't have to be here;
  • the circles are a bit tricky in this challenge: I have used pseudo-elements, position absolute, vw and vh, background url, transform translate and @media;
  • transfer footer to the bottom and center it.

  Greetings :D

  2

  ---

  

  Michael Newman•45

  @mikeronewmanPosted almost 4 years ago

  @SzymonRojek thank you so much for your input, very helpful advice!

  0
• Account deleted

  Hello, I think all has been said by Szymon. Nice project, it's overall well done! :D

  0