Submitted about 2 years ago

Responsive Room ecomerce landing page with sass and vanilla Javascript

Joshua Ajorgbor•210

@JAjorgbor

Preview site View code

This is a solution for...Room homepage

HTML
CSS
JS

3intermediate

Design comparison

SolutionDesign

Solution retrospective

This challenge although simple on the surface level really helped me realize my layout skills especially when it came to using grid to make it responsive overall I'm happy with the final outcome and would like to make more use of the new things I learnt while doing this. (p.s I would like if anyone can give me some advice on how to properly make my sites more browser compatible especially with safari).

Community feedback

Adriano•38,330
@AdrianoEscarabotePosted about 2 years ago
Hi Joshua Ajorgbor, how are you?

I really liked the result of your project, but I have some tips that I think you will like:

1- All page content should be contained by landmarks, you can understand better by clicking here: click here

We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

Example:

native HTML5 reference elements:

<body> <header>This is the header</header> <nav>This is the nav</nav> <main>This is the main</main> <footer>This is the footer</footer> </body>

ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

<body> <div role="banner">This is the header</div> <div role="navigation">This is the nav</div> <div role="main">This is the main</div> <div role="contentinfo">This is the footer</div> </body>

It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

Link to read more about: click here

2- Why it Matters

Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

Rule Description

It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

Link to read more about: click here

Prefer to use rem over px to have your page working better across browsers and resizing the elements properly

The rest is great!!

Hope it helps...👍
Marked as helpful
0

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord