Responsive Rock Paper Scissors with Randomize house option

Community feedback

• 

  P

  Karthik suryadevara•825

  @karthik2265Posted almost 2 years ago

  Hey staticish,

  looks good, well done

  putting the border and adding a bonus button on the Title component was a good idea.

  some things to improve:

  • sizing of the text and images, just making them a little bigger would make it look a lot better
  • the bonus button and the play again button does not show any feedback to the user when hovered or clicked, you can add some by changing the cursor to pointer on hover and scaling the button to 0.9 when active.
  • try to put less logic in the html part, this would make the code more readable ,example:

  {state.userOption === null ? (
          <>
            {state.bonus ? (
              <Pentagon getId={getId} />
            ) : (
              <Triangle getId={getId} />
            )}) : (
          <GamePlay
            usersOption={state.userOption}
            houseOption={state.houseOption}
            results={state.results}
            playAgain={() => {
              dispatch({ type: "reset" });
            }}
          />
        )}
  // you could wrap this  in a function call or make it a component and use it
  

  • try using scoped css with css modules

  1

  ---

  

  staticish•190

  @staticishPosted almost 2 years ago

  @karthik2265 wdym by less logic? I should keep the Pentagon and Triangle logic in a component called <Levels />. Something like that?

  0

  

  P

  Karthik suryadevara•825

  @karthik2265Posted almost 2 years ago

  @staticish yes that's what I meant

  0