Design comparison
SolutionDesign
Community feedback
- @MURRAY122Posted over 2 years ago
Hi Yonas,
Congrats on the challenge! I had a quick look at the code and have some tips for you.
- Your
container-submit
is hidden behind yourcontainer
. Perhaps using a custom class such as.hide { display: none }
would be more suitable? Then once the user has hit submit you could use JavaScript to remove the hide class fromcontainer-submit
and apply it to your firstcontainer
. You can learn more on how to add and remove classes with JavaScript. - I also noticed that on the mobile view the first
container
seems too large. You could use media queries to change the style of that class. For example..
@media screen and (max-width: 375px) { .container { width: 0; height: 0; } }
Any classes within that media query will be applied when the users screen is no more than 375px wide. You could also change it to
min-width: 375px
which means any classes within the media query will apply when the users screen is more than 375px, depending on your preference.Marked as helpful1 - Your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord