Responsive Results-summary-page #1

Community feedback

• Account deleted

  Hi there!! ✌️

  Congrats on completing this challenge!! 🥳

  Answering your question.

  You can use BEM Methodology, this methodology helps you to create shorter and more efficient code, and thus avoid specificity problems.

  Also here are some tips to improve your code... 🙃

  HTML: 🧱

  Your main content should be inside the main tag, more info here

  You should not forget to use the h1 tag, it is very important on your website. You must remember that it is only used once, and continue successively with h1, h2, ..., h6 and NOT SKIP HEADER LEVELS. More info about that here

  Your img tags must have the alt attribute. You should not forget it. More info here

  CSS: 🎨

  I can see that you have a little reset for the default styles that the browser gives, that's ok. But you can improve it by using other resets like the following:

  • Normalize.css
  • Reset.css
  • My Custom CSS Reset of Josh Comeau

  Your solution is very good. 💯

  Happy coding! ✌️🙃

  Marked as helpful

  1
• 

  Ayush Kanyal•120

  @ayushkanyalPosted about 1 year ago

  Hey Christian,

  Thank you so much for your thorough feedback! I have improved my solution because of your insights. I did the following changes:

  1. Added main tag to contents section.
  2. Alt text attributes for image elements.
  3. An h1 heading to help screen readers identify the main heading of the page.

  0