Responsive results-summary-component

Community feedback

• 

  Pavel B.•270

  @JagholinPosted over 1 year ago

  Great job! I only looked in DevTools, but havent found much to complain about.

  What can be improved:

  • It's just my personal preference, but in many cases you dont need display: flex; flex-direction: column, the default flow layout does many things just fine. It also does margin collapsing, which can be either good or bad(depends whether you are used to it or not).

  • width: 100% does nothing for display: block elements, and might even be harmful sometimes

  Marked as helpful

  1

  ---

  

  Walid-Gs•220

  @Walid-GsPosted over 1 year ago

  • @Jagholin , thank you so much for your feedback, i really appreciate it.

  • and yes, you are totally right block elements (display: block) takes the whole view port width by default.

  0