Responsive results summary using CSS grid and Flexbox

Community feedback

• 

  Joachim•840

  @Thewatcher13Posted over 1 year ago

  Hi helen,

  Well done, but like your other project, the strong elements isn't a good idea for the same reason. (The element strong is used for give more meaning on an element, not for provide any kind of styling. Screenreaders by example go read your strong elements with more emphasis, and in this case that would be make no sense.)

  You should use an ul, instead of span here (what it would be in a plain text)

  Marked as helpful

  2

  ---

  

  Helen Chong•190

  @helenclxPosted over 1 year ago

  @Thewatcher13 Thanks for your feedback. My code for this project has been updated based on your suggestions.

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  DECORATIVE SVG'S ♨️:

  • The alt attribute is used to provide alternative text for images in HTML documents. The alt attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.

  ---

  • Now, when it comes to decorative SVGs, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.

  ---

  • Since these images do not convey any important information or functionality, there is no need for an alt attribute.

  ---

  • So feel free to set the alt attribute as "" for decorative svg's, because alt="" will be skipped by screen readers they will consider the image as decoration

  ---

  Example:

  <img src="images/decorative.svg" alt="">
  
  

  <img src="./assets/images/icon-reaction.svg" alt="Reaction icon">
  👇
  <img src="./assets/images/icon-reaction.svg" alt="">
  
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Helen Chong•190

  @helenclxPosted over 1 year ago

  @0xAbdulKhalid Thank you for your feedback. I have updated my HTML based on your suggestions.

  0
• 

  Arif Faisal•580

  @arifaisal123Posted over 1 year ago

  A very good effort! However, you may want to check out different devices in the mobile responsive version (using chrome developer tools) as I found white padding/margin at the top where the purple section is not completely aligned.

  1

  ---

  

  Helen Chong•190

  @helenclxPosted over 1 year ago

  @arifaisal123 Thank you for your feedback. However, I have checked the responsive version of my solution using the developer tools on both Firefox and Chrome, and I am unable to find the white padding/margin you mentioned. Would you mind sharing a screenshot of what my solution looks like on your screen?

  0

  

  Arif Faisal•580

  @arifaisal123Posted over 1 year ago

  @helenclx I tried it on samsung galaxy A51/A71. It appears on some mobile screens. You can check the SS below:

  https://ibb.co/BND57xR

  Marked as helpful

  1

  

  Helen Chong•190

  @helenclxPosted over 1 year ago

  @arifaisal123 Thanks for the reply. I have refactored my CSS to fix the white padding/margin issue on certain mobile screens.

  1