Responsive Results Summary Components with position property

Community feedback

• 

  Rajaul Islam Ratul•1,250

  @ratul0407Posted about 1 year ago

  @PriyanshuPrama12 congrats on completing this awesome project.😀😀

  You've done a really great job. But you might consider changing some codes:

  • Each page should contain a level one heading <h1>. So you can replace the text your result from <h6> to an <h1>.
  • You've used position relative on your #section__box--circle to place the <h2> and <p> underneath it. Well if you have a good grasp on position tag and you are comfortable with positioning elements there is nothing bad about using it. But in this example you clearly don't need to position it. You can just use a div and and then .section__box1 will have three child elements inside of it and you can just use

  .section__box1 {
    display: flex;
    flex-direction: column;
    gap: 2rem; //or whatever you feel matches the design better🌝
    }
  
  

  In this way you don't have to write that much of code and don't have to add that much complexity in your code.

  I hope that helped🌝🌝

  Keep up the good work

  Marked as helpful

  1

  ---

  

  Priyanshu Pramanik•380

  @Priyanshu-WDPosted about 1 year ago

  Thank you @ratul0407, looking to my code, and for the suggestion!

  1