@rohitd99
Posted
Hi Dale
Congrats on your first submission 🥳.
First of all I noticed that you have applied media queries for making it responsive but you made a small mistake since you set the max-width
property on results div for desktop size, you need to make it max-width : none
on mobile sizes for it to be responsive. That max-width
property was not letting the results div cover the whole width. Other than that I would also recommend you to use semantic elements such as main
, section
, article
etc instead of div
. You may read on them here.
Good luck for other challenges.
Marked as helpful
@daletorres
Posted
Really appreciate the input Rohit! I knew I was doing something wrong with the media queries lol, I'm going to check all of the things you pointed out and do the challenge again. @rohitd99