Design comparison
Solution retrospective
The most difficult thing (for me) about this challenge is to guess the nearest value of margins, padding, and width based on the provided design. As much as possible, I wanted my solution to be identical to the design, so I struggled while trying to experiment with different combinations. But in terms of the ability to analyze and build the markup, I'm very happy that I was able to do it quickly (well I guess this is what you call progress) unlike before.
Prior to my knowledge, this is the best that I can do for now! I'll accept criticism, advice, and corrections! I would really appreciate it if you can give your thoughts on my solutions!
Again, I made it responsive thanks to the god..... DISPLAY FLEX PROPERTY! HAHAHA!
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML π·οΈ:
- This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to
non-semantic
markup, which lack landmark for a webpage
- So fix it by replacing the
<div class="first-container">
element with the semantic element<main>
in yourindex.html
file to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
- They convey the structure of your page. For example, the
<main>
element should include all content directly related to the page's main idea, so there should only be one per page
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0 - @0xabdulPosted over 1 year ago
Hey there well congrats on completing the Results summary component..π€©
- A little suggestion for improve your code ..
- In Html π·οΈ :
- the html page should be contained one main landmarkβ
- What Is Landmark β
- The main landmark should be a top-level landmark. When a page contains nested document and/or application roles (e.g. typically through the use of iframe and frame elements), each document or application role may have one main landmark. If a page includes more than one main landmark, each should have a unique label.
- to clear the Accessibility reports use sematic elements or non semantic elements..
- th html page should be contained one main landmark so fix them
- to clear the Accessibility reports using semantic elements or non semantic elements
- for easy way to clear the all Accessibility reports using non - semantic elements Ex :
<div> , <span>
- let's try
- Ex :
<body> <div class="container" role="main"> //Html code here π·οΈ </div> </body>
- OR
- using semantic elements Ex :
<aside> <section> <main> <nav> <header> < footer>
- Ex :
<body> <header>company logo header name...</header> <main> the main content here</main> <footer>@Copy right Here</footer> </body> </html>
- I Hope you find the solution and it's useful for you π
- **Happy Coding
arjuyyy
π€©
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord