Responsive Results Summary Component using FlexBox and Grid

Community feedback

• 

  Sonsawan Ngamsom•140

  @murphy6867Posted over 1 year ago

  All of it's rather that would be great, but still missing about size of the box.

  • Imagine In the content-box have 2 components, You build 2 square box in component, I think it would be event better if you did 2 vertical rectangle
  • And the good practice you should have to wrap container in the <main> element and attribution in the <footer> element. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly : https://laylacodes.hashnode.dev/what-is-semantic-html

  After committing the changes on GitHub and you need to deploy it as a live site. Finally, you should click generate a new report on this solution page to clear the warnings.

  Hope I am helpful. :)

  Marked as helpful

  0
• 

  Mustafa•210

  @mnoorhussinPosted over 1 year ago

  Great Work! I have some points that may help you.

  • Use proper indentation to improve the readability of the code, try to write separate CSS and JS files.

  • Consider using CSS variables for colors, fonts, and other properties that are repeated throughout the code. This will make it easier to make changes to the design in the future.

  • Use relative units like em or rem instead of absolute units like px for font sizes and dimensions. This will make the design more responsive to different screen sizes and devices.

  • Make sure to use alt attributes on images to improve accessibility and search engine optimization: <span><img src="${icon}" alt="">${category}</span>

  Marked as helpful

  0