Design comparison
Solution retrospective
Hi All,
All feedback Welcome.
Community feedback
- @Zy8712Posted about 1 year ago
Your solution is very solid. Great work!!
The only main thing I'd suggest you to do is the remove repeated lines of code that appear both insider and outside your media query. Such as
display: flex
that appears in your.container
class inside and outside your media query. You only need it once outside your media query and it carries over.Hope this helps ๐
Marked as helpful0 - @MelvinAguilarPosted about 1 year ago
Hello there ๐. Good job on completing the challenge !
I have some small suggestions about your code that might interest you.
- You should use the
cursor: pointer
property to indicate that the element like a button or a link is clickable.
- For icons, you should still use the alt attribute, but it should be empty (
alt=""
). This indicates to screen readers and other assistive technologies that the icon is decorative and that they should skip over it
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0 - You should use the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord