Responsive result summary page using FlexBox, JSON and JavaScript

Community feedback

• 

  Ishmael•330

  @IshmaelsealeyPosted over 1 year ago

  Hey There!

  Well done on completing the challenge using the provided .json file! (I struggled to implement it 😅)

  I have some suggestions you may take into consideration.

  • The index.html file contains two <h1> tags. The h1 is the most important heading on any given page, and as such, there should only be one of them. Including only one h1 also improves the accessibility of your website for screen readers!
  • The circle containing the average result is correctly using a gradient, however the gradient should be linear-gradient( ); as opposed to radial-gradient( );.
  • The button also uses a gradient background in the hover state. The gradient is the same as the one used for the background of the .left-section

  I hope you find my suggestions helpful! Happy coding!!

  Marked as helpful

  0

  ---

  

  Gaganpreet Kaur•40

  @GaganpreetKaurGillPosted over 1 year ago

  @Ishmaelsealey Thanks for your feedback. I will keep the suggestion in mind for new challenges.

  0
• 

  kadu20es•100

  @kadu20esPosted over 1 year ago

  Your design is really good. By looking at it I just learned how to center any element (vertically and horizontally) and the usage of CSS variables to define values of properties.

  Congrats and thank your for sharing!

  0

  ---

  

  Gaganpreet Kaur•40

  @GaganpreetKaurGillPosted over 1 year ago

  @kadu20es Thanks .. Appreciate your kind words!!

  0